Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defmt, bump heapless, add additional CI build variants, fix serde+no_std #49

Merged
merged 3 commits into from
Dec 28, 2024

Conversation

mchodzikiewicz
Copy link
Contributor

Hi,

I just started using mqttrs for my project, take a look at few changes that I needed to apply.

If you want, I can split it into multiple PRs but the scope is not that big (even though it is not "atomic").

@mchodzikiewicz mchodzikiewicz changed the title Add defmt, bump versions, add additional CI build variants, fix serde+no_std Add defmt, bump heapless, add additional CI build variants, fix serde+no_std Dec 18, 2024
@00imvj00
Copy link
Owner

@mchodzikiewicz getting this error while running tests, please check.

Compiling mqttrs v0.4.1 (/home/runner/work/mqttrs/mqttrs)
     Running `/home/runner/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/rustc --crate-name mqttrs --edition=2018 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --emit=dep-info,link -C embed-bitcode=no -C debuginfo=2 --test --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values("default", "defmt", "derive", "serde", "std"))' -C metadata=72e5bfe7f0d7eadd -C extra-filename=-72e5bfe7f0d7eadd --out-dir /home/runner/work/mqttrs/mqttrs/target/debug/deps -C incremental=/home/runner/work/mqttrs/mqttrs/target/debug/incremental -L dependency=/home/runner/work/mqttrs/mqttrs/target/debug/deps --extern heapless=/home/runner/work/mqttrs/mqttrs/target/debug/deps/libheapless-72d9beaf7b37443a.rlib --extern proptest=/home/runner/work/mqttrs/mqttrs/target/debug/deps/libproptest-82824e0ff27f59cf.rlib`
error[E0432]: unresolved import `bytes`
 --> src/decoder_test.rs:2:5
  |
2 | use bytes::BytesMut;
  |     ^^^^^ use of undeclared crate or module `bytes`
For more information about this error, try `rustc --explain E0[43](https://github.com/00imvj00/mqttrs/actions/runs/12466435357/job/34794956689?pr=49#step:8:44)2`.
error: could not compile `mqttrs` (lib test) due to 1 previous error
Caused by:
  process didn't exit successfully: `/home/runner/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/rustc --crate-name mqttrs --edition=2018 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --emit=dep-info,link -C embed-bitcode=no -C debuginfo=2 --test --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values("default", "defmt", "derive", "serde", "std"))' -C metadata=72e5bfe7f0d7eadd -C extra-filename=-72e5bfe7f0d7eadd --out-dir /home/runner/work/mqttrs/mqttrs/target/debug/deps -C incremental=/home/runner/work/mqttrs/mqttrs/target/debug/incremental -L dependency=/home/runner/work/mqttrs/mqttrs/target/debug/deps --extern heapless=/home/runner/work/mqttrs/mqttrs/target/debug/deps/libheapless-72d9beaf7b37[44](https://github.com/00imvj00/mqttrs/actions/runs/12466435357/job/34794956689?pr=49#step:8:45)3a.rlib --extern proptest=/home/runner/work/mqttrs/mqttrs/target/debug/deps/libproptest-82824e0ff27f59cf.rlib` (exit status: 1)

@mchodzikiewicz
Copy link
Contributor Author

I am sorry, I pushed half-baked commit to this branch instead of a separate one by mistake, pipeline is green again on my fork

@00imvj00 00imvj00 self-requested a review December 28, 2024 14:22
@00imvj00 00imvj00 merged commit 0f1ce9d into 00imvj00:master Dec 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants