Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TorConfig.Setting.extraInfo should be Map<Extra, Any> #350

Closed
05nelsonm opened this issue Mar 26, 2024 · 0 comments · Fixed by #352
Closed

TorConfig.Setting.extraInfo should be Map<Extra, Any> #350

05nelsonm opened this issue Mar 26, 2024 · 0 comments · Fixed by #352
Milestone
2.0.0-alpha01

Comments

@05nelsonm
Copy link
Owner

05nelsonm commented Mar 26, 2024 •
edited
Loading

There should be some sort of type safety when it comes to extras. Need to delegate allowPortReasignment from TorRuntime to the config setting which should be able to include the option individually on ports.
@05nelsonm 05nelsonm added this to the 2.0.0-alpha01 milestone Mar 26, 2024
@05nelsonm 05nelsonm changed the title TorConfig.Setting.extraInfo should be Map<String, Any> TorConfig.Setting.extraInfo should be Map<Extra, Any> Mar 26, 2024
@05nelsonm 05nelsonm mentioned this issue Apr 9, 2024
Merged
@05nelsonm 05nelsonm linked a pull request Apr 9, 2024 that will close this issue
Move allowPortReassignment to individual port settings as an extra #352
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0-alpha01
Development

Successfully merging a pull request may close this issue.

Move allowPortReassignment to individual port settings as an extra 05nelsonm/kmp-tor
1 participant
@05nelsonm