You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the second line from this screenshot plays, voice and text are not in sync: first the voice plays over an empty textbox, and then the text appears when she already stops talking.
I had a look, and this is the offending code.
// だから一連の事件も、犯人は誰かってことよりも、事件の存在自体が、古い因習がまだ根深く残ってることの証拠だって思って面白がってるくらい...。@ModPlayVoiceLS(4, 9, "ps3/s19/09/500900070", 256, TRUE);
if (GetGlobalFlag(GADVMode)) { OutputLine("<color=#f6d9a8>鷹野</color>", NULL, "<color=#f6d9a8>Takano</color>", NULL, Line_ContinueAfterTyping); }
if (GetGlobalFlag(GADVMode)) { OutputLine(NULL, "", NULL, "<size=-2>", Line_Continue); }
OutputLine(NULL, " だから一連の事件も、犯人は誰かってことよりも、事件の存在自体が、古い因習がまだ根深く残ってることの証拠だって思って面白がってるくらい…。」",
NULL, "So even for this string of incidents, it's not so much finding out who the culprit is, but enjoying thinking about how the old traditions displayed by the incidents themselves still seems to have some pretty deep roots around here...\"", GetGlobalFlag(GLinemodeSp));
if (GetGlobalFlag(GADVMode)) { ClearMessage(); } else { OutputLineAll(NULL, "\n\n", Line_ContinueAfterTyping); }
The line causing the issue is if (GetGlobalFlag(GADVMode)) { OutputLine(NULL, "", NULL, "<size=-2>", Line_Continue); } immediately following the ModPlayVoiceLS(...) command.
I guess auto mode assumes that the voice is associated with the immediate next line. This line is blank (ignoring the size tag), so it holds the blank line on screen until the voice ends. Once the voice ends, it shows the "correct" line, but at that point the voice has already stopped playing.
While I could try to move the <size=-2> command back in the script, fixing it in the engine would fix all instances of this bug across all chapters.
I think skipping "empty" lines in auto mode will fix it. However I need to figure out how the engine parses tags, so that it can ignore the tags on the line (maybe it's easy, I've just never looked at that part of the code before).
The text was updated successfully, but these errors were encountered:
Problem
It was reported on discord
I had a look, and this is the offending code.
The line causing the issue is
if (GetGlobalFlag(GADVMode)) { OutputLine(NULL, "", NULL, "<size=-2>", Line_Continue); }
immediately following theModPlayVoiceLS(...)
command.I guess auto mode assumes that the voice is associated with the immediate next line. This line is blank (ignoring the size tag), so it holds the blank line on screen until the voice ends. Once the voice ends, it shows the "correct" line, but at that point the voice has already stopped playing.
More instances: 07th-mod/watanagashi@d66fa0b
Fix
While I could try to move the
<size=-2>
command back in the script, fixing it in the engine would fix all instances of this bug across all chapters.I think skipping "empty" lines in auto mode will fix it. However I need to figure out how the engine parses tags, so that it can ignore the tags on the line (maybe it's easy, I've just never looked at that part of the code before).
The text was updated successfully, but these errors were encountered: