-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load tips title text and other strings from JSON file instead of being hardcoded #79
Comments
I've added a feature where the mod can load strings from a However, I still need to go through the chapters which have the tips menu text and add a function call to get the text from the I've decided to keep this separate from the The format is like this: {
"allChapters":
{
"no-tips-available" : {
"comment": "This text appears at the top of the tips menu when there are no tips available",
"text": "No new tips available",
"textJP": "入手TIPSはありません"
}
}
} Which is deserialized into the following C# class (can add more fields later): public class LocalizationEntry
{
public string comment;
public string text;
public string textJP;
}
public class LocalizationInfo
{
public Dictionary<string, LocalizationEntry> allChapters;
public LocalizationInfo()
{
allChapters = new Dictionary<string, LocalizationEntry>();
}
} |
Some translation teams have translated the mod menu (F10 menu) text - these texts should be added to the |
Currently, the tips menu text is hardcoded:
See this line of code: https://github.com/07th-mod/higurashi-assembly/blob/matsuri-mod/Assets.Scripts.UI.Tips/TipsManager.cs#L69
It would be better to load it from the tips.json file (if the field exists, to keep compatibility with older tips.json files)
I need to make some other changes to the DLL - this fix can be bundled with it.
The text was updated successfully, but these errors were encountered: