Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Linux Resolution / Windowed-Fullscreen Issues #94

Closed
4 tasks done
drojf opened this issue Nov 5, 2022 · 2 comments
Closed
4 tasks done

Minor Linux Resolution / Windowed-Fullscreen Issues #94

drojf opened this issue Nov 5, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@drojf
Copy link
Contributor

drojf commented Nov 5, 2022

I noticed these minor issues which probably aren't related to this issue, but might be. I've seen some of them before but didn't note them down anywhere. I'll raise another issue later with these items once this PR is closed.

  • One small issue I noticed (I don't think it's due to this issue), is that on my system I can forcibly resize the window by dragging it to touch the top of the screen (this kind of pins it as windowed mode, but fills the whole screen). Once it is in this state, you can't change the windowed resolution (it will change briefly, then change back). Going fullscreen, then back to windowed doesn't fix the issue. You need to drag the window out of the pinned state, then it returns to normal.

    • This seems very much like a window manager thing so I don't think we can fix this, but may be worth noting.
    • I retested this. On Ch.1, I can't pin the window, but on Ch.10 (hou+), I can. On ch.10 there is still some weird behavior, but now it will revert to fullscreen in most instances. You can also press ALT+SPACE to open a menu, then click "Move" to move the window if it is in an awkward location.
  • Another unrelated? issue I noticed is that I can set the windowed resolution greater than the resolution of my screen (for example, set 2560x1440 when my screen is 1920x1080). Changing to a lower windowed resolution is then only possible if you go fullscreen again via a hotkey, which is complicated by the next issue (because you cannot see the resolution change buttons anymore as they are off the screen).

    • I should check whether the Windows version lets you do this or not, or if it caps the resolution.
    • Fixed by preventing setting a res greater than the screen res + revert to fullscreen if resolution not set correctly check 746ea08
  • Going fullscreen via the f key only works if you're not in a menu - you have to be in normal mode - 'StateNormal' as it is called in DLL I think.

    • This one should be pretty easy to fix.
    • Fixed 7cf8aef
  • Using ALT-Enter to change from windowed to fullscreen has no effect (hopefully it's not my laptop keyboard setup or something). I thought I noticed the window trying to change resolution when I pressed alt-enter, but I can't seem to reproduce it.

Originally posted by @drojf in #93 (comment)

@drojf drojf added the bug Something isn't working label Aug 11, 2024
@drojf
Copy link
Contributor Author

drojf commented Aug 11, 2024

Just an update (2024) that while investigating another issue (07th-mod/hou-plus#13), I found all the above issues still exist (and also exist on Hou+).

I found another issue

  • (Affects all OS) On the main config menu (not the F10 menu), after going fullscreen, the button for the current resolution (eg 1080p) will stay "clicked". This prevents you from going back to windowed at the same resolution (you need to click one of the other resolutions like 720p to go back to windowed).

    • Fixed (tested on Windows)
  • On hou+, if you try to set a windowed resolution greater than your monitor resolution, it doesn't set it, but it also doesn't set one of the pre-defined resolutions like on Windows (eg on Windows if you click 2440p and your screen is 1080p, it will revert to 1080p). It also results in the mouse cursor not aligning with what is on the screen anymore.

    • Fixed by reverting the resolution if it was detected as not being set correctly, after 10 frames have passed. Tested on Linux

The 'f' key and 'alt-enter' are the most annoying ones, esp if you accidentally set a resolution when you can't see the buttons anymore.

drojf added a commit to drojf/higurashi-assembly-2 that referenced this issue Aug 12, 2024
drojf added a commit to drojf/higurashi-assembly-2 that referenced this issue Aug 12, 2024
drojf added a commit to drojf/higurashi-assembly-2 that referenced this issue Aug 12, 2024
drojf added a commit to drojf/higurashi-assembly-2 that referenced this issue Aug 12, 2024
drojf added a commit to drojf/higurashi-assembly-2 that referenced this issue Aug 12, 2024
drojf added a commit to drojf/higurashi-assembly-2 that referenced this issue Aug 12, 2024
drojf added a commit that referenced this issue Aug 22, 2024
drojf added a commit that referenced this issue Aug 22, 2024
@drojf
Copy link
Contributor Author

drojf commented Sep 14, 2024

Minor issues fixed, however please note this major issue with tall aspect ratios is still a problem: #133

@drojf drojf closed this as completed Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant