Text speed overriden for too long

[drojf]

We had a report that the text speed was not obeyed. It turned out that we had a SetSpeedOfMessage( TRUE, 128 ); without a corresponding SetSpeedOfMessage( FALSE, 0 );

Starts on line 436:

tsumihoroboshi/Update/_tsum_012_2.txt

Line 436 in 32b8274

SetSpeedOfMessage( TRUE, 128 );

Your screenshot is line 764:

tsumihoroboshi/Update/_tsum_012_2.txt

Line 764 in 32b8274

NULL, "Ever since Rina called me Reina, I've hated that name more than ever. Because of that, I didn't have a good first impression of this man.", Line_Normal);

Finishes on line 1052:

tsumihoroboshi/Update/_tsum_012_2.txt

Lines 1052 to 1056 in 32b8274

	SetSpeedOfMessage( TRUE, 128 );
	ModPlayVoiceLS(4, 1, "ps3/s09/01/170100484", 256, TRUE);
	OutputLine(NULL, "　取ったぁ！！",
	NULL, " I got it!!", Line_Continue);
	SetSpeedOfMessage( FALSE, 0 );

I asked orian and it should be fine to remove it.

---

I decided to scan all our game scripts for similar issues (for cases where at least 500 japanese characters are emitted or end of file was reached):

If it says "at EOF", it means the file was missing a SetSpeedOfMessage( FALSE, 0 ); before the file ended. I'm not sure if you require this in a script file or it will carry over to the next script file.

The ones marked "DUP" mean that two SetSpeedOfMessage( True, ...) were encountered without having a corresponding SetSpeedOfMessage( FALSE, ...)

• Text: 786 Forced Lines: 156 in file 5 meakashi\Update_meak_020.txt at line 5212-5368
• Text: 786 Forced Lines: 156 in file 5 meakashi\Update_meak_020.txt at line 5212-5368 DUP
• Text: 861 Forced Lines: 194 in file 5 meakashi\Update_meak_ep_01.txt at line 11-205
• Text: 1366 Forced Lines: 452 in file 5 meakashi\Update_meak_ep_02.txt at line 186-638 DUP

---

• Text: 390 Forced Lines: 146 in file 6 tsumihoroboshi\Update_tsum_003_3.txt at line 1738-1884 (at EOF)
• Text: 2017 Forced Lines: 620 in file 6 tsumihoroboshi\Update_tsum_012_2.txt at line 436-1056 DUP
• Text: 6473 Forced Lines: 1265 in file 6 tsumihoroboshi\Update_tsum_013.txt at line 1226-2491 (at EOF)
• Text: 534 Forced Lines: 279 in file 6 tsumihoroboshi\Update_tsum_tips_005.txt at line 15-294

Some of these I fixed by comparing with the unmodded game, but even in the unmodded game there was one place where I'm pretty sure it was missing a text speed reset.

---

• Text: 4109 Forced Lines: 1111 in file 7 minagoroshi\Update_mina_002_1.txt at line 4478-5589
• Text: 3167 Forced Lines: 722 in file 7 minagoroshi\Update_mina_006.txt at line 1061-1783 DUP
• Text: 5278 Forced Lines: 1477 in file 7 minagoroshi\Update_mina_008.txt at line 1098-2575 DUP
• Text: 1462 Forced Lines: 360 in file 7 minagoroshi\Update_mina_013.txt at line 704-1064 DUP
• Text: 2016 Forced Lines: 767 in file 7 minagoroshi\Update_mina_013.txt at line 3042-3809 DUP
• Text: 10438 Forced Lines: 2068 in file 7 minagoroshi\Update_mina_014.txt at line 978-3046 (at EOF) DUP
• Text: 1750 Forced Lines: 346 in file 7 minagoroshi\Update_mina_019.txt at line 3264-3610 DUP
• Text: 2402 Forced Lines: 599 in file 7 minagoroshi\Update_mina_022.txt at line 1192-1791
• Text: 2478 Forced Lines: 690 in file 7 minagoroshi\Update_mina_022.txt at line 1924-2614 DUP
• Text: 1323 Forced Lines: 355 in file 7 minagoroshi\Update_mina_028.txt at line 1919-2274 DUP

---

• Text: 1532 Forced Lines: 336 in file 8 matsuribayashi\Update_kakera01.txt at line 347-683 DUP
• Text: 123 Forced Lines: 61 in file 8 matsuribayashi\Update_kakera03.txt at line 1318-1379 (at EOF)
• Text: 718 Forced Lines: 188 in file 8 matsuribayashi\Update_kakera08.txt at line 421-609 DUP
• Text: 2598 Forced Lines: 511 in file 8 matsuribayashi\Update_kakera26.txt at line 20-531 DUP
• Text: 4299 Forced Lines: 872 in file 8 matsuribayashi\Update_kakera38.txt at line 33-905 (at EOF) DUP
• Text: 1010 Forced Lines: 195 in file 8 matsuribayashi\Update_kakera51.txt at line 895-1090 DUP
• Text: 1627 Forced Lines: 395 in file 8 matsuribayashi\Update_kakera51.txt at line 1182-1577 DUP
• Text: 505 Forced Lines: 381 in file 8 matsuribayashi\Update_mats_009.txt at line 2750-3131
• Text: 2180 Forced Lines: 522 in file 8 matsuribayashi\Update_mats_010.txt at line 1130-1652 (at EOF)
• Text: 7642 Forced Lines: 1708 in file 8 matsuribayashi\Update_mats_013.txt at line 1401-3109 (at EOF)
• Text: 1717 Forced Lines: 440 in file 8 matsuribayashi\Update_mats_019.txt at line 3173-3613 DUP
• Text: 522 Forced Lines: 176 in file 8 matsuribayashi\Update_mats_022.txt at line 2849-3025 DUP
• Text: 5279 Forced Lines: 1226 in file 8 matsuribayashi\Update_mats_023.txt at line 1237-2463

---

• Text: 779 Forced Lines: 254 in file 9 higurashi-rei\Update\batsukoishi01.txt at line 3602-3856 DUP
• Text: 1491 Forced Lines: 376 in file 9 higurashi-rei\Update\hirukowashi02_3.txt at line 929-1305
• Text: 711 Forced Lines: 242 in file 9 higurashi-rei\Update\hirukowashi02_3.txt at line 1418-1660
• Text: 684 Forced Lines: 178 in file 9 higurashi-rei\Update\hirukowashi03.txt at line 1673-1851
• Text: 614 Forced Lines: 148 in file 9 higurashi-rei\Update\saikoroshi03.txt at line 2035-2183
• Text: 1420 Forced Lines: 417 in file 9 higurashi-rei\Update\staffroom.txt at line 175-592 DUP

Here is the python script I was using to scan:
scan.zip