Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All-Cast Review suddenly mentions console arc #102

Open
deepFlaw opened this issue Jul 25, 2020 · 0 comments
Open

All-Cast Review suddenly mentions console arc #102

deepFlaw opened this issue Jul 25, 2020 · 0 comments

Comments

@deepFlaw
Copy link
Contributor

I noticed that in the All-Cast Review Session there is this odd line that assumes the player has played Taraimawashi:

20200725135714_1

Since it would be extremely unlikely that a PC player had read that already - even in the console arc flowchart, it branches off from Tatarigoroshi - to me this feels like a line that shouldn't be updated when on lower voice matching levels. It's minor, but it was jarring for me when I read through it today, and for a minute I thought I'd somehow skipped something! It looks like the un-updated line is just " ...Both this time and last time.", which makes more sense.

I'm up for making this change myself, especially as I'd already be making a pull request for a different small change in this section. The problem is that I am unclear on if there's a policy for a specific voice matching level (GCensor value?) that should be used. Is that up to my discretion - in which case I'd probably set the current line to happen at 3, so it's higher than the default 2 - or are there clearer guidelines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant