Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove no-op line #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove no-op line #50

wants to merge 1 commit into from

Commits on Oct 6, 2024

  1. Remove no-op line 

    The removed line is imho unnecessary and can be removed for two reasons:

1) Float32Array.set takes an array and an optional numeric
   However, in the removed line, these parameters were passed
   in switched order, resulting in a no-op (afaict)

2) It seems that the idea was to zero the elements in the
   array because the last chunk is smaller than the array size.
   However, the array is already created with its values set
   to 0.
    @ReneNyffenegger
    ReneNyffenegger committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    073d4e4 View commit details
    Browse the repository at this point in the history