Bug: Custom date format breaks repos

[BreadKat0707]

Before you start

• Have you updated FluentHub? You might be using an old version.
• Have you checked if a similar issue has already been reported?

What version of Windows is this issue present?

Windows 11 Dev

What version/architecture of FluentHub are you on?

0.8.60.0 | X64 | RELEASE

Description

When I try to open a repository, the page content flashes and then says Something went wrong string "time" was not recognized as a valid datetime

Steps To Reproduce

No response

Expected behavior

Successfully open a repo page

Stack Trace

Stack trace details

at System.DateTimeOffset.Parse(String input)
at FluentHub.Octokit.Queries.Repositories.TreeQueries.GetWithObjectNameAsync(String name, String owner, String refs, String path)
at FluentHub.App.ViewModels.Repositories.Codes.DetailsLayoutViewModel.LoadRepositoryContentsAsync(String login, String name, String branch, String path)
at FluentHub.App.ViewModels.Repositories.Codes.DetailsLayoutViewModel.LoadDetailsViewPageAsync()

Assets

2023-12-31 22:18:50.777 +08:00 [ERR] LoadRepositoryContentsAsync
System.FormatException: String '2023.12.31.星期日 上午 08:28:59' was not recognized as a valid DateTime.
at System.DateTimeOffset.Parse(String input)
at FluentHub.Octokit.Queries.Repositories.TreeQueries.GetWithObjectNameAsync(String name, String owner, String refs, String path)
at FluentHub.App.ViewModels.Repositories.Codes.DetailsLayoutViewModel.LoadRepositoryContentsAsync(String login, String name, String branch, String path)
at FluentHub.App.ViewModels.Repositories.Codes.DetailsLayoutViewModel.LoadDetailsViewPageAsync()
2023-12-31 22:20:18.782 +08:00 [ERR] LoadRepositoryContentsAsync
System.FormatException: String '2023.03.29.星期三 上午 10:04:46' was not recognized as a valid DateTime.
at System.DateTimeOffset.Parse(String input)
at FluentHub.Octokit.Queries.Repositories.TreeQueries.GetWithObjectNameAsync(String name, String owner, String refs, String path)
at FluentHub.App.ViewModels.Repositories.Codes.DetailsLayoutViewModel.LoadRepositoryContentsAsync(String login, String name, String branch, String path)
at FluentHub.App.ViewModels.Repositories.Codes.DetailsLayoutViewModel.LoadDetailsViewPageAsync()

[0x5bfa]

Thank you for the feedback. I guess Chinese version date time string is not recognized as a valid DataTime conversion target. I'm gonna investigate the cause and fix, but note that I don't have much time these days.

[Lamparter]

This issue is not related to Chinese DateTime format. Instead, it is about the date format being set in a format that is not default for the system, as explained by @just.a.hriday on Discord:

Oh I know the problem
I've gone and changed the windows short date format to a custom format
Because I wanted to see the day of the week in the taskbar
So ddd, d MMMM isn't a format microsoft expects
And DateTime.Parse doesn't support it
But yeah, it's the same thing as in the issue you mentioned - the user's computer has a short date format that DateTime.Parse doesn't support.
I wonder what you could do about that though

[Lamparter]

Cannot reproduce after 4 attempts with different time format combinations, exactly matching the ones shown by @BreadKat0707 and @just.a.hriday 😕

[just-a-hriday]

It's also weird to me that the bug for me occured on the date of a seemingly random commit from the repository. Why not one of the other commits?

[just-a-hriday]

Cannot reproduce after 4 attempts with different time format combinations, exactly matching the ones shown by @BreadKat0707 and @just.a.hriday 😕

Looks like you've changed the time format - the issue is with the short date one.

[Lamparter]

Cannot reproduce after 4 attempts with different time format combinations, exactly matching the ones shown by @BreadKat0707 and @just.a.hriday 😕

Looks like you've changed the time format - the issue is with the short date one.

How do you mean?

[just-a-hriday]

The bug seems to be caused by the Short date format. The one in your screenshot is supported by DateTime.Parse(), but mine is not.