Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the tx kernel lib from miden-base for linking in MidenTxKernelLibrary #307

Open
greenhat opened this issue Sep 6, 2024 · 3 comments
Milestone

Comments

@greenhat
Copy link
Contributor

greenhat commented Sep 6, 2024

At

pub struct MidenTxKernelLibrary(CompiledLibrary);

Rather than using the stubs, link the real tx kernel library from miden-base compiled at https://github.com/0xPolygonMiden/miden-base/blob/159d55a1e9f74dc8451b338076f87a1dfad9a179/miden-lib/build.rs#L66

@bitwalker
Copy link
Contributor

bitwalker commented Sep 6, 2024

As a note on this - where I'd like to go with these key Miden libraries, consists of a couple steps:

EDIT: Moved to #316

@greenhat
Copy link
Contributor Author

greenhat commented Sep 9, 2024

Sounds great! Thanks for the thorough explanation. Your comment deserves to be an issue for miden toolchain.

@greenhat greenhat added this to the Beta 1 milestone Sep 10, 2024
@bitwalker
Copy link
Contributor

Created #316 as the tracking issue for midenc toolchain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants