Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for account ID prefix uniqueness during block proving #1158

Open
PhilippGackstatter opened this issue Feb 17, 2025 · 2 comments
Open
Milestone

Comments

@PhilippGackstatter
Copy link
Contributor

What should be done?

After #1157, we can check for account ID uniqueness.

How should it be done?

As part of building ProposedBlock, in AccountUpdateAggregator::aggregate_account, we can check for uniqueness by inspecting the SmtLeaf of the SmtProof. If it is not of variant SmtLeaf::Empty, this would be an error. (This assumes the witness would contain such a proof after the account tree is built on top of Smt).
Later we'll have to also implement this check in MASM, but that's a separate issue.

When is this task done?

Once implemented and existing tests pass and a new test checking for the error condition has been added.

Additional context

No response

@bobbinth bobbinth added this to the v0.9 milestone Feb 17, 2025
@bobbinth
Copy link
Contributor

The idea here is to make sure no two account share the same 64-bit prefix, right?

@PhilippGackstatter PhilippGackstatter changed the title Check for account ID uniqueness during block proving Check for account ID prefix uniqueness during block proving Feb 18, 2025
@PhilippGackstatter
Copy link
Contributor Author

The idea here is to make sure no two account share the same 64-bit prefix, right?

Yes, exactly. The title was a bit imprecise so I changed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants