Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change TransactionAuthenticator's get_signature to be async #1162

Open
tomyrd opened this issue Feb 17, 2025 · 3 comments
Open

feat: change TransactionAuthenticator's get_signature to be async #1162

tomyrd opened this issue Feb 17, 2025 · 3 comments

Comments

@tomyrd
Copy link
Collaborator

tomyrd commented Feb 17, 2025

Stemming from this comment. We should change the authenticator to allow async signature requests. This could be done by changing the trait to async or to maybe_async if we want to allow both options.

@varun-doshi
Copy link
Contributor

I'd like to take this

@bobbinth
Copy link
Contributor

Thank you @varun-doshi! But this is actually not a very straight-forward task which may require refactoring in the VM or other places. The main issue is that we can't easily move from sync to async context and back, especially in web assembly. There is one potential approach for how to handle this described in #401 (comment).

@varun-doshi
Copy link
Contributor

Ahh I see
In that case, I can close the PR or if someone wants to work off of the PR? (although there isn't much code change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants