Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move structs to domain module. #571

Closed
igamigo opened this issue Nov 1, 2024 · 1 comment
Closed

Move structs to domain module. #571

igamigo opened this issue Nov 1, 2024 · 1 comment
Assignees
@SantiagoPittella
Milestone
v0.7.0

Comments

@igamigo
Copy link
Collaborator

igamigo commented Nov 1, 2024

As part of adding new RPC endpoints (0xPolygonMiden/miden-base#951), structs like AccountData were added to the rpc module to represent RPC responses converted to domain structs.

These should be better placed on the domain module instead, so we should move them.
@igamigo igamigo mentioned this issue Nov 7, 2024
Closed
@SantiagoPittella SantiagoPittella self-assigned this Nov 22, 2024
@SantiagoPittella SantiagoPittella mentioned this issue Nov 22, 2024
Merged
@igamigo igamigo added this to the v0.7.0 milestone Dec 2, 2024
@igamigo
Copy link
Collaborator Author

igamigo commented Dec 2, 2024

Closed by #608, #610, #615

@igamigo igamigo closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SantiagoPittella SantiagoPittella

Labels
None yet
Projects
User's testnet
Status: Done
Milestone
v0.7.0
Development

No branches or pull requests
2 participants
@igamigo @SantiagoPittella