Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Of particular concern is that by manipulating the degree of the #707

Open
recmo opened this issue Jun 8, 2020 · 0 comments
Open

Of particular concern is that by manipulating the degree of the #707

recmo opened this issue Jun 8, 2020 · 0 comments
Assignees
Labels
refactor Improves the code quality tracker Issues generated from source comments

Comments

@recmo
Copy link
Contributor

recmo commented Jun 8, 2020

On 2020-06-08 @pvienhage wrote in 18f47a6 “Autogen Bug Fixes to Rust Code (#706)”:

Of particular concern is that by manipulating the degree of the
claimed interpolating polynomial of the modifications modifications can
unchecked in the proof.

    info!("Combine rational expressions");
    let mut combined_constraints = constraints.combine(constraint_coefficients);
    // At this point the constraint's have had degrees assigned which
    // match those where the claim polynomials aren't specified.
    // TODO - This substitution lowers overall security and should be validated.
    // TODO - Of particular concern is that by manipulating the degree of the
    // claimed interpolating polynomial of the modifications modifications can
    // unchecked in the proof.
    combined_constraints = combined_constraints.substitute_claim(&constraints.claim_polynomials);
    constraints.substitute();

    let mut dag = AlgebraicGraph::new(
        &FieldElement::generator(),

From crypto/stark/src/prover.rs:572

@recmo recmo added refactor Improves the code quality tracker Issues generated from source comments labels Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Improves the code quality tracker Issues generated from source comments
Projects
None yet
Development

No branches or pull requests

2 participants