Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't play well with openzepplin #68

Open
cedricwalter opened this issue Apr 5, 2021 · 5 comments
Open

don't play well with openzepplin #68

cedricwalter opened this issue Apr 5, 2021 · 5 comments

Comments

@cedricwalter
Copy link

cedricwalter commented Apr 5, 2021

Thanks for this great library! but updating openzeppelin-solidity to latest 4.0.0 and I can not compile my project

running but outdated combination taken from https://github.com/ProjectOpenSea/opensea-erc1155

    "multi-token-standard": "github:ProjectOpenSea/multi-token-standard",
    "openzeppelin-solidity": "^2.1.3",

How to reproduce, upgrading 3rd parties

openzeppelin-solidity 4.0.0    // use pragma solidity ^0.8.0;
@0xsequence/erc-1155 3.0.4    // use use pragma solidity ^0.7.4;

Tried both

    solc: {
      version: "^0.8.0",
    },

,ParserError: Source file requires different compiler version (current compiler is 0.8.3+commit.8d00100c.Emscripten.clang) - note that nightly builds are considered to be strictly less than
the released version
 --> @0xsequence/erc-1155/contracts/tokens/ERC1155/ERC1155MintBurn.sol:2:1:
  |
2 | pragma solidity 0.7.4;

or

    solc: {
      version: "^0.7.4",
    },

,ParserError: Source file requires different compiler version (current compiler is 0.8.3+commit.8d00100c.Emscripten.clang) - note that nightly builds are considered to be strictly less than
the released version
 --> @0xsequence/erc-1155/contracts/tokens/ERC1155/ERC1155MintBurn.sol:2:1:
  |
2 | pragma solidity 0.7.4;

what do you recommend? rollbacking openzeppelin-solidity to a previous version? hoping that I find one which stilluse Solc 0.7 branch?

@pkieltyka
Copy link
Member

@cedricwalter thanks for the report -- I've noticed you closed this ticket -- did you find a solution? any updates on your experience?

thanks

@cedricwalter
Copy link
Author

Yes and no, I switched to a pure Open Zeppelin ERC1155 implementation. I closed this report since it is not really an error, mixing 2 library (yours and open zeppelin), and adding truffle is something you may not want to urgently fix.

@pkieltyka
Copy link
Member

Cool thanks. I'll reopen for us to look into some time in the future

@pkieltyka pkieltyka reopened this Apr 5, 2021
@aalmada
Copy link

aalmada commented May 4, 2022

I actually prefer this implementation but want to use some other contracts from Open Zeppelin. I run into this same issue. Are you planning to upgrade to 0.8.*?

@pkieltyka
Copy link
Member

@aalmada yes we will – it will be an easy upgrade too.

curious which parts you prefer in this implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants