Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onClose callback #222

Merged
merged 3 commits into from
Jan 7, 2025
Merged

onClose callback #222

merged 3 commits into from
Jan 7, 2025

Conversation

SamueleA
Copy link
Contributor

@SamueleA SamueleA commented Dec 17, 2024 •
edited
Loading

onClose callback called when on the modals involved in the payment flow is closed.

@SamueleA SamueleA marked this pull request as ready for review December 18, 2024 21:45
@SamueleA SamueleA requested review from 0xsequence-bot and a team as code owners December 18, 2024 21:45
AlexanderKolberg
AlexanderKolberg approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@AlexanderKolberg AlexanderKolberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corbanbrook corbanbrook merged commit 955b497 into master Jan 7, 2025
1 check passed
@corbanbrook corbanbrook deleted the 3776-onClose-callback branch January 7, 2025 16:45
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
@corbanbrook
Build: (955b497) onClose callback (#222)
b32b9a7 
* onClose callback

* moved onClose callback at the top level of the pending credit card component

* missing onClose callback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderKolberg AlexanderKolberg AlexanderKolberg approved these changes

@corbanbrook corbanbrook corbanbrook approved these changes

@0xsequence-bot 0xsequence-bot Awaiting requested review from 0xsequence-bot 0xsequence-bot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamueleA @corbanbrook @AlexanderKolberg