-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the README.md and add a COD.md #11
Comments
I am not sure if a Code of conduct is needed in the codebase. We already have one on the website as well as in the discord channel. If anything, Contribution Rules might be beneficial. |
sure let me work on it to fit for just contribution rules |
https://github.com/excalidraw/excalidraw/blob/master/CONTRIBUTING.md This can be an idea, to be adjusted for the Issue -> PR workflow that we adapted. |
I don't think we need a CoC in this repo. We do need however contributing guidelines and rules. Not sure what yet tho, open to suggestions or maybe find a really solid one and translate it over to here? |
I do think contribution guidelines are important , what if someone wants to contribute and they're not part of the discord ? |
Yeah, that's what I meant too haha, sorry if it came out the opposite way. Contribution guidelines ARE important - Code of conduct is what's not (for this repo). My couple ideas of what should the guidelines contain (not comprehensive)
|
See the Frontend's PR template, it's great: 100DaysOfCloud/100DaysOfCloudFrontend#28 (comment) |
Thanks , Chris this looks like a good start, closing the issue now |
#So i already created 2 pull requests i wasn't aware i should open an issue before doing that , @antoniolofiego pointed that out after i already did. Basically what i did was modify the READ.md and i noticed that there was no code of conduct , so jotted something real quick that can be modified at any point.
The text was updated successfully, but these errors were encountered: