Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean out Amplify's legacies #33

Open
what-name opened this issue Jul 29, 2020 · 4 comments
Open

Clean out Amplify's legacies #33

what-name opened this issue Jul 29, 2020 · 4 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@what-name
Copy link
Collaborator

The Amplify app has been completely disconnected from this repository because of the repo name change. It did not follow the changes in this repository and no matter what happens here (either on main or staging), it will not be reflected on the current Amplify app. As seen below, the latest update to the live app was f6be3f9
Screen Shot 2020-07-29 at 13 27 40
Screen Shot 2020-07-29 at 13 28 15
Screen Shot 2020-07-29 at 13 26 46

What I don't understand at all is why the last build (Build 4) is saying it happened yesterday (today is 29th) when that merge was 11 days ago.

I just disabled auto build for the main environment as well for good measure, since it did not break or change anything for the staging environment when that got disabled a while back.
Screen Shot 2020-07-29 at 13 45 59

Conclusion

  • There is no point in keeping or updating the main branch of this repository or Amplify code that's in there, it is isolated from everything. We should clear everything out in the main branch to avoid confusion and put a well-detailed README of where things are at.
  • We should create a new branch here called dev as staging is not what we're doing right now and it is just confusing. The main branch would hold the explanation README and the dev branch would hold all our backend code for now. When production will be deployed, the main branch will be populated and a CI/CD pipeline will handle everything from the get-go.
  • After the dev branch is an exact copy, delete staging branch.
  • Furthermore, can we please delete branches after they're merged and not leave them dangle?
@what-name
Copy link
Collaborator Author

what-name commented Jul 29, 2020

@rishabkumar7 mentioned that some new changes (the ones seen above) should be pushed to the current app. Reconnecting the main branch of this repo for that would be pretty overkill IMO. It can be solved however with creating a new repo (backend-amplify) and connecting the Amplify App back to that, as it's the exact same if it gets connected to this repo or a new one, as long as the files are the same. This repo should focus on the new architecture and not seperate completely different backends onto two branches, as it stands currently.

Creating a new repo with a 1:1 copy of this' main and connecting the Amplify app to that is pretty easy however.

@rishabkumar7 rishabkumar7 self-assigned this Jul 29, 2020
@antoniolofiego antoniolofiego added this to the Backend milestone Jul 29, 2020
@antoniolofiego antoniolofiego added the help wanted Extra attention is needed label Jul 29, 2020
@rishabkumar7
Copy link
Member

The old gatsby site is moved to 100daysOfCloudLegacy repo.
Its been deployed to new AWS Amplify App until we get the new site setup, it will serve the 100daysofcloud.com

@what-name
Copy link
Collaborator Author

The new repository that's connected to the Amplify App is 100DaysOfCloudLegacy - it holds the original (old) Amplify code but it got seperated from this repository. This repository is murky on branches and was therefore split up into 100DaysOfCloudLegacy & 100DaysOfCloudBackend. This repository was also renamed to 100DaysOfCloudBackendLegacy from 100DaysOfCloudBackend.

Keep issue open until the new 100DaysOfCloudBackend repository holds a copy of the latest backend SAM app (template).

@what-name what-name reopened this Jul 29, 2020
@antoniolofiego
Copy link
Collaborator

antoniolofiego commented Jul 29, 2020

Keep issue open until the new 100DaysOfCloudBackend repository holds a copy of the latest backend SAM app (template).

Agree with this, it should be also linked to #34.

@antoniolofiego antoniolofiego pinned this issue Jul 29, 2020
@antoniolofiego antoniolofiego unpinned this issue Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants