Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI/CD pipeline to build and deploy the frontend #26

Open
antoniolofiego opened this issue Aug 3, 2020 · 3 comments
Open

Set up CI/CD pipeline to build and deploy the frontend #26

antoniolofiego opened this issue Aug 3, 2020 · 3 comments
Assignees
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@antoniolofiego
Copy link
Collaborator

antoniolofiego commented Aug 3, 2020

There is currently no pipeline or deployment of the new frontend. To be able to work on both the front and backend, there needs to be a complete dev environment deployed incorporating both. The pipeline is very similar to the current cicd/codepipeline-dev.template.yaml template in the backend repo.

We should create two separate stacks for frontend and backend, given that all the interactions between the two rely exclusively on REST APIs.

@what-name
Copy link
Collaborator

  • Deployment GitHub Action merged with Add deploy to S3 GitHub Action - #26 #33 - it deploys the dev branch's contents into the dev bucket and CF distribution
  • The current workflow does not invalidate CloudFront cache, TTL can be set to a minimum on the dev version in order to aviod having to manually invalidate it. It is not set like that currently, so please let me know what you think on that. (it's simple to change)
  • There is no testing or linting in the workflow itself, should/could there be something?
  • Resources (S3 bucket, CF distribution, IAM user who's access keys are being used, etc.) are deployed within the backend stack. Since we switched to GitHub Actions instead of CodeBuild, it is a much cleaner solution that avoids having to maintain and deploy a tiny template from this repo seperately.
  • We should add a badge to the README to see if the deployment is failing or passing (it's always good to see that upfront)
  • Here is the development CloudFront URL: https://d2tz5aklrov90y.cloudfront.net

@what-name what-name added the question Further information is requested label Aug 6, 2020
@rishabkumar7
Copy link
Member

@rishabkumar7
Copy link
Member

Added the following 2 for now, we can discuss what all badges we need.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants