Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProfileBadge needs to have an option to align the content of the badge to the left. #35

Closed
Bruck1701 opened this issue Aug 11, 2020 · 0 comments · Fixed by #34
Closed
Assignees
Labels
bug Something isn't working

Comments

@Bruck1701
Copy link
Contributor

Version Information

What is the expected behavior?

the ProfileBadge should have an option to justify the content to the left as well, so when we add different users together in a table, their images will be aligned.

What is the actual behavior?

Now, the ProfileBadge has a hard coded 'justify-center' to the card that holds the user information. In the Journeyers Table, with users with different length of names, the images don't align nicely...

Other notes on how to reproduce the issue?

The grid in front of the image of the table shows how the avatars of the users are misaligned!
misalignedImages

Any possible solutions?

Adding an option to the ProfileBadge to align the images to the left fixes the issue on the Journeyers page.

Can you identify the location in the source code where the problem exists?

yes, line 38 of ProfileBadge.js

If the bug is confirmed, would you be willing to submit a PR?

Yes, the solution is ready. As soon as the issue is recognized, I'll submit the PR.

@Bruck1701 Bruck1701 added the bug Something isn't working label Aug 11, 2020
@Bruck1701 Bruck1701 self-assigned this Aug 11, 2020
@antoniolofiego antoniolofiego added this to the Full component suite milestone Aug 11, 2020
@antoniolofiego antoniolofiego linked a pull request Aug 11, 2020 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants