style(api): reword eligibility function fr to en

1024pix · Feb 7, 2025 · bb247c6 · bb247c6
1 parent 85f416b
commit bb247c6
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/api/src/quest/domain/models/Eligibility.js b/api/src/quest/domain/models/Eligibility.js
@@ -18,15 +18,15 @@ export class Eligibility {
    * @param {number} campaignParticipationId
    */
   hasCampaignParticipation(campaignParticipationId) {
-    return Boolean(
-      this.campaignParticipations.find((campaignParticipation) => campaignParticipation.id === campaignParticipationId),
+    return this.campaignParticipations.some(
+      (campaignParticipation) => campaignParticipation.id === campaignParticipationId,
     );
   }
 
   /**
    * @param {number} campaignParticipationId
    */
-  scoperALaParticipationUniquement({ campaignParticipationId }) {
+  buildEligibilityScopedByCampaignParticipationId({ campaignParticipationId }) {
     return new Eligibility({
       organizationLearner: this.organizationLearner,
       organization: this.organization,

diff --git a/api/src/quest/domain/models/Quest.js b/api/src/quest/domain/models/Quest.js
@@ -22,7 +22,7 @@ class Quest {
    * @param {number} campaignParticipationId
    */
   isCampaignParticipationContributingToQuest({ eligibility, campaignParticipationId }) {
-    const scopedEligibility = eligibility.scoperALaParticipationUniquement({ campaignParticipationId });
+    const scopedEligibility = eligibility.buildEligibilityScopedByCampaignParticipationId({ campaignParticipationId });
     const isCampaignParticipationType = (requirement) => requirement.type === ELIGIBILITY_TYPES.CAMPAIGN_PARTICIPATIONS;
     const isNotCampaignParticipationType = (requirement) =>
       requirement.type !== ELIGIBILITY_TYPES.CAMPAIGN_PARTICIPATIONS;

diff --git a/api/tests/quest/unit/domain/models/Eligibility_test.js b/api/tests/quest/unit/domain/models/Eligibility_test.js
@@ -28,8 +28,8 @@ describe('Quest | Unit | Domain | Models | Eligibility ', function () {
     });
   });
 
-  describe('#scoperALaParticipationUniquement', function () {
-    it('doit retourner une nouvelle instance Eligibility scopée uniquement sur la participation passée en paramètre', function () {
+  describe('#buildEligibilityScopedByCampaignParticipationId', function () {
+    it('return new instance of Eligibility scoped on given CampaignParticipation', function () {
       // given
       const organization = Symbol('orga');
       const organizationLearner = Symbol('orgaLearner');
@@ -41,10 +41,12 @@ describe('Quest | Unit | Domain | Models | Eligibility ', function () {
       });
 
       // when
-      const eligibilityScopee = eligibility.scoperALaParticipationUniquement({ campaignParticipationId: 2 });
+      const scopedEligibility = eligibility.buildEligibilityScopedByCampaignParticipationId({
+        campaignParticipationId: 2,
+      });
 
       // then
-      expect(eligibilityScopee).to.deepEqualInstance(
+      expect(scopedEligibility).to.deepEqualInstance(
         new Eligibility({
           organization,
           organizationLearner,