Fix: Updates tiptap/core dependency to fix space trim issue #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidnelson777
changed the title
davidnelson777
force-pushed
the
Update_tiptap_dependency_to_fix_issue_247
branch
from
a525265 to
a6c64d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this solve?
Any time you have two words with bold, italic, underline, etc, formatting on them and a space between them without any of that format, it is removed when used as the initialContent for the editor.
closes #247
How does this solve it?
Updates the dependency for tiptap/core to 2.5.5 where this issue was resolved in the base library.
See:
https://github.com/ueberdosis/tiptap/pull/4838/files#diff-4b20a33fe5fc9a20a2ec6cd2a45a0d7df7167ca7aff4612cb3a530864e4265eb
and:
ueberdosis/tiptap#4792 (comment)
Test plan:
You should see a new lib-web folder, and inside index.mjs around line the 10372
r.nodeType === 3 && r.nodeValue && !/\S/.test(r.nodeValue) ? n.removeChild(r) : r.nodeType === 1 && Mi(r);should be replaced by
r.nodeType === 3 && r.nodeValue && /^(\n\s\s|\n)$/.test(r.nodeValue) ? n.removeChild(r) : r.nodeType === 1 && Ca(r);