Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the request to authenticate Azure AI Vision credentials works #852

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Feb 13, 2025

Description of the Change

In trying to set up a new site using Azure AI Vision for some of our image processing functionality, ran into an error when first authenticating: Either 'features' or 'model-name' needs to be specified in the query parameter

This isn't an issue I've seen before so I'm assuming they changed something within their API to require one of those two fields. We currently don't pass either when validating credentials and thus our validation never passes and Azure AI Vision can never be set up.

This PR fixes that by passing in ?features=caption to ensure that value exists.

How to test the Change

  1. In a new environment, setup the Descriptive Text Generator Feature
  2. Choose Microsoft Azure AI Vision as the Provider
  3. Enter valid credentials and ensure things save successfully

Changelog Entry

Fixed - Ensure the Azure AI Vision Provider authenticates properly

Credits

Props @dkotter

Checklist:

@dkotter dkotter added this to the 3.3.0 milestone Feb 13, 2025
@dkotter dkotter self-assigned this Feb 13, 2025
@dkotter dkotter requested review from jeffpaul and a team as code owners February 13, 2025 19:59
@github-actions github-actions bot added the needs:code-review This requires code review. label Feb 13, 2025
@dkotter dkotter requested review from iamdharmesh and removed request for a team and jeffpaul February 13, 2025 19:59
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dkotter

@iamdharmesh iamdharmesh merged commit cf0a938 into develop Feb 14, 2025
19 checks passed
@iamdharmesh iamdharmesh deleted the fix/azure-ai-vision-auth branch February 14, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants