Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[찬우] globalThis 번역 #32

Merged
merged 46 commits into from
Jun 21, 2023
Merged

[찬우] globalThis 번역 #32

merged 46 commits into from
Jun 21, 2023

Conversation

chanuuuuu
Copy link
Contributor

No description provided.

1101707 and others added 30 commits March 15, 2023 01:21
ko : proposal-object-getownpropertydescriptors 번역 완료
3900c88
@chanuuuuu
summary : proposal-object-getownpropertydescriptors 요약 1차 완료
2ccb500
@chanuuuuu
Merge branch 'main' into main
b799a26
@chanuuuuu
Merge branch '11st-corp:main' into main
cc5f6e9
@chanuuuuu
summary : proposal-object-getownpropertydescriptors proto 관련 내용 추가
85c49b7
@chanuuuuu
summary : proposal-object-getownpropertydescriptors appendix 추가
8ee2e0f
@chanuuuuu
summary : proposal-object-getownpropertydescriptors appendix 수정
8ab1f70
@chanuuuuu
summary : proposal-object-getownpropertydescriptors appendix Object.a…
8ab4025 
…ssign 추가
@chanuuuuu
ko : proposal-dotAll-flag-for-reglar-expressions
2a38a08
@chanuuuuu
delete : proposal-dotAll-flag-for-reglar-expressions branch 분리를 위한 삭제
193181c
@chanuuuuu
Merge branch 'main' into main
4a21a62
@chanuuuuu @huckjoo
Update src/ko/proposal-object-getownpropertydescriptors.md
1104c24 
Co-authored-by: HyukJoo Kwon <[email protected]>
@chanuuuuu @huckjoo
Update src/ko/proposal-object-getownpropertydescriptors.md
d855099 
Co-authored-by: HyukJoo Kwon <[email protected]>
@chanuuuuu @huckjoo
Update src/ko/proposal-object-getownpropertydescriptors.md
f98c490 
Co-authored-by: HyukJoo Kwon <[email protected]>
@chanuuuuu @huckjoo
Update src/ko/proposal-object-getownpropertydescriptors.md
46c1716 
Co-authored-by: HyukJoo Kwon <[email protected]>
@chanuuuuu @huckjoo
Update src/ko/proposal-object-getownpropertydescriptors.md
f59b405 
Co-authored-by: HyukJoo Kwon <[email protected]>
@chanuuuuu @huckjoo
Update src/ko/proposal-object-getownpropertydescriptors.md
f0ba809 
Co-authored-by: HyukJoo Kwon <[email protected]>
@chanuuuuu @huckjoo
Update src/ko/proposal-object-getownpropertydescriptors.md
9440594 
Co-authored-by: HyukJoo Kwon <[email protected]>
@chanuuuuu @huckjoo
Update src/ko/proposal-object-getownpropertydescriptors.md
65d4860 
Co-authored-by: HyukJoo Kwon <[email protected]>
@chanuuuuu @huckjoo
Update src/ko/proposal-object-getownpropertydescriptors.md
d3390a0 
Co-authored-by: HyukJoo Kwon <[email protected]>
@chanuuuuu
ko : proposal-object-getownpropertydescriptors 번역 수정
1343dec
@chanuuuuu
summary : proposal-object-getownpropertydescriptors-appendix 추가 수정 (미완)
12733da
@chanuuuuu
Merge branch '11st-corp:main' into main
b8c7115
@chanuuuuu
Merge branch '11st-corp:main' into main
a28eab1
@chanuuuuu
ko : proposal-promise-finally 번역 완료
f4f684a
@chanuuuuu
Merge branch '11st-corp:main' into main
8f86516
@chanuuuuu
Merge branch 'main' into main
6c5b958
@chanuuuuu
Merge remote-tracking branch 'origin'
7522605
@chanuuuuu
Merge branch 'main' into main
f1440dd
@chanuuuuu
Merge branch '11st-corp:main' into main
f6cbbe5
damilog
damilog approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@damilog damilog left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~! 꼼꼼하게 잘 해주셨네요 고생 많으셨습니다. 맥락상 눈에 띄는 부분에 대해 리뷰드렸습니다!
PR에 포함된 커밋이 많군요~!
질문 주신 내용 이 PR에 코멘트 드렸는데 혹 해결이 불가하면 말씀주세요!

src/ko/proposal-global.md Outdated Show resolved Hide resolved
src/ko/proposal-global.md Outdated Show resolved Hide resolved
src/ko/proposal-global.md Outdated Show resolved Hide resolved
src/ko/proposal-global.md Outdated Show resolved Hide resolved
src/ko/proposal-global.md Outdated Show resolved Hide resolved
src/ko/proposal-global.md Outdated Show resolved Hide resolved
src/ko/proposal-global.md Outdated Show resolved Hide resolved
huckjoo
huckjoo approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@huckjoo huckjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ LGTM

src/ko/proposal-global.md Outdated Show resolved Hide resolved
hochan222
hochan222 requested changes Jun 8, 2023
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다!!

몇가지 리뷰사항 남겨두었습니다 :)

src/ko/proposal-global.md Outdated Show resolved Hide resolved
src/ko/proposal-global.md Outdated Show resolved Hide resolved
src/ko/proposal-global.md Outdated Show resolved Hide resolved
src/ko/proposal-global.md Outdated Show resolved Hide resolved
src/ko/proposal-global.md Outdated Show resolved Hide resolved
src/ko/proposal-global.md Outdated Show resolved Hide resolved
src/ko/proposal-global.md Outdated Show resolved Hide resolved
src/ko/proposal-global.md Outdated Show resolved Hide resolved
chanuuuuu and others added 14 commits June 21, 2023 23:58
@chanuuuuu @hochan222
Update src/ko/proposal-global.md
3e4dccc 
Co-authored-by: hochan Lee <[email protected]>
@chanuuuuu @hochan222
Update src/ko/proposal-global.md
1bbf5bc 
감사합니다.

Co-authored-by: hochan Lee <[email protected]>
@chanuuuuu @huckjoo
Update src/ko/proposal-global.md
6590d75 
Co-authored-by: HyukJoo Kwon <[email protected]>
@chanuuuuu @damilog
Update src/ko/proposal-global.md
65dac6b 
Co-authored-by: Dami Kim <[email protected]>
@chanuuuuu @damilog
Update src/ko/proposal-global.md
2b5b3c4 
Co-authored-by: Dami Kim <[email protected]>
@chanuuuuu @damilog
Update src/ko/proposal-global.md
8718029 
Co-authored-by: Dami Kim <[email protected]>
@chanuuuuu @damilog
Update src/ko/proposal-global.md
de3166a 
Co-authored-by: Dami Kim <[email protected]>
@chanuuuuu @damilog
Update src/ko/proposal-global.md
8d1f9bf 
Co-authored-by: Dami Kim <[email protected]>
@chanuuuuu @hochan222
Update src/ko/proposal-global.md
e3dbb14 
Co-authored-by: hochan Lee <[email protected]>
@chanuuuuu @damilog
Update src/ko/proposal-global.md
b7e46ab 
Co-authored-by: Dami Kim <[email protected]>
@chanuuuuu @damilog
Update src/ko/proposal-global.md
6de8f75 
Co-authored-by: Dami Kim <[email protected]>
@chanuuuuu @hochan222
Update src/ko/proposal-global.md
06f175f 
Co-authored-by: hochan Lee <[email protected]>
@chanuuuuu @hochan222
Update src/ko/proposal-global.md
668ce9d 
Co-authored-by: hochan Lee <[email protected]>
@chanuuuuu
Merge branch 'main' into globalThis
b240a87
@chanuuuuu chanuuuuu requested a review from hochan222 June 21, 2023 15:00
hochan222
hochan222 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다. LGTM :)

@hochan222 hochan222 merged commit 14c23d6 into 11st-corp:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huckjoo huckjoo huckjoo approved these changes

@damilog damilog damilog approved these changes

@hochan222 hochan222 hochan222 approved these changes

Assignees

@chanuuuuu chanuuuuu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chanuuuuu @hochan222 @damilog @huckjoo