-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shouldn't this be wrapped in an article? #137
Comments
Hi @inetbiz!
I don't think that this should be wrapped in an
The infobox could be an aside. However, given that the point of that infobox is to be read and then deleted, I don't think there's much value is making this change, though I wouldn't mind if that change was made.
I don't think the infobox should gain a
In the same article, they note that the
Since I don't think this page should gain an |
Line 39 does NEED a footer. You can't insert a colophone in the content above the The copyright is related to doc and even mozilla says this is where copyright marks should be contained. See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/footer |
Apologies, in my original reply I was refferring to the For the content on line 39, I don't see anything about it that means it must be within a footer. The MDN article you link to suggests what may typically go into a footer, but nothing there suggests to me that what's written on line 39 must be a footer. Can you priovide some more information on why you think line 39 must be a footer?
I'm afraid I don't follow this. I'm not sure what copyright marks you are referring to. What I read on line 39 is some information and useful links about the template. That sounds like the main content for this page. Can you clarify what you mean here please? Anyway, the content we're discussing is an initial signposting for users of this template, and is surrounded by a "Delete this message" instruction. While I support adopting more semantic elements where it makes sense, I'm not sure changing this content will add any more value to the template. |
eleventy-base-blog/_includes/layouts/base.njk
Lines 30 to 43 in aa0db14
Shouldn't this be wrapped in an HTML5 article and an aside for the infobox? The infobox could have a
rel=help
.eleventy-base-blog/_includes/layouts/base.njk
Line 39 in aa0db14
This should be
footer
content in the article.eleventy-base-blog/_includes/layouts/base.njk
Line 46 in aa0db14
The text was updated successfully, but these errors were encountered: