Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style grade nested+empty let expressions/local declarations #3

Open
T-Brick opened this issue May 31, 2022 · 0 comments
Open

Style grade nested+empty let expressions/local declarations #3

T-Brick opened this issue May 31, 2022 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@T-Brick
Copy link
Member

T-Brick commented May 31, 2022

Issue

Currently, we allow empty let expressions (ones with no declarations), as well as nested let expressions (similarly for local declarations). For instance,

val _ =
    let
    in
        150
    end

val _ =
    let
        val x = 50
    in
        let
            val y = 100
        in
            x + y
        end
    end

Is there any reason we should allow this? Should we even bother creating rules for these? I know anecdotally some students have said that they didn't know you could put multiple declarations in a let expression, maybe having a style rule like that would help?

Next Steps

λdditional Info

  • Relevant Semester: F21

Successor issue to https://github.com/15-150/15150/issues/1744

@T-Brick T-Brick added enhancement New feature or request question Further information is requested labels May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant