Bugfix: Some options were not being saved (#191)

1984hosting · Aug 6, 2024 · 75baccd · 75baccd
1 parent 0931b2e
commit 75baccd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/js/admin.js b/js/admin.js
@@ -90,6 +90,8 @@ class NineteenEightyWoo {
 			make_credit_invoice: Boolean( formData.get( 'make_credit_invoice' ) ),
 			domestic_customer_ledger_code: formData.get( 'domestic_customer_ledger_code' ),
 			international_customer_ledger_code: formData.get( 'international_customer_ledger_code' ),
+			use_attribute_description: Boolean( formData.get( 'use_attribute_description' ) ),
+			use_attribute_value_description: Boolean( formData.get( 'use_attribute_value_description' ) ),
 			product_convertion_to_variation_enabled: Boolean( formData.get( 'product_conversion' ) ),
 			fetch_products: true
 		}

diff --git a/src/Config.php b/src/Config.php
@@ -746,7 +746,7 @@ public static function get_use_attribute_description(): bool {
 	public static function set_use_attribute_description( bool $value ): bool {
 		return update_option(
 			'1984_woo_dk_use_attribute_description',
-			(bool) $value
+			(int) $value
 		);
 	}
 
@@ -776,7 +776,7 @@ public static function set_use_attribute_value_description(
 	): bool {
 		return update_option(
 			'1984_woo_dk_use_attribute_value_description',
-			(bool) $value
+			(int) $value
 		);
 	}
 

diff --git a/views/admin.php b/views/admin.php
@@ -185,7 +185,7 @@ class="regular-text api-key-input"
 						<td>
 							<input
 								id="use_attribute_description_label_field"
-								name="use_attribute_description_label"
+								name="use_attribute_description"
 								type="checkbox"
 								<?php echo esc_attr( Config::get_use_attribute_description() ? 'checked' : '' ); ?>
 							/>
@@ -208,7 +208,7 @@ class="regular-text api-key-input"
 						<td>
 							<input
 								id="use_attribute_description_value_field"
-								name="use_attribute_description_value"
+								name="use_attribute_value_description"
 								type="checkbox"
 								<?php echo esc_attr( Config::get_use_attribute_value_description() ? 'checked' : '' ); ?>
 							/>