Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] name block must be mandatory #133

Open
Vijitverm1234 opened this issue Oct 1, 2024 · 8 comments
Open

[Feat] name block must be mandatory #133

Vijitverm1234 opened this issue Oct 1, 2024 · 8 comments
Assignees
Labels
good first issue Good for newcomers gssoc-ext Issues under GSSoC label will be counted for GSSoC'24 extended hacktoberfest

Comments

@Vijitverm1234
Copy link
Contributor

Vijitverm1234 commented Oct 1, 2024

  • Without entering the name, It's processing to show a wife
Copy link

github-actions bot commented Oct 1, 2024

Hi there! Thanks for opening this issue. We appreciate your contribution to this open-source project. We aim to respond or assign your issue as soon as possible.

@manu-hn
Copy link

manu-hn commented Oct 1, 2024

Hey, @1Shubham7 @Vijitverm1234 as mentioned here, the issue occurs when the username is not entered, yet it still processes to show a wife. I would like to work on this issue and will try to address all the points mentioned.

@Vatsal-Verma
Copy link

Screenshot 2024-10-01 225717

  1. Instead for writing this below, we can make a pop up note at the time when person enters in the website , More like an authentication.

Screenshot 2024-10-01 230100

  1. Even if we leave the field empty , it finds a wife for you. Which mean that it finds a wife for no one. We need to validate this field.

@1Shubham7
Copy link
Owner

hey @Vijitverm1234, thanks for opening this issue, in order to make the development process smoother, we usually keep one fix or similar fixes in a single issue.

I think you can make this issue about the first point you made. please edit your comment accordingly. Assigning this to you, please do inform if you are not able to work so that other contributors can make a try : )

@1Shubham7
Copy link
Owner

hey @Vijitverm1234, please come up with a more specific issue name and also remove unwanted points from your comment, that helps us track issues efficiently so that duplicate issues are not created : )

@Vijitverm1234
Copy link
Contributor Author

@1Shubham7 done with editing my comment

@1Shubham7
Copy link
Owner

please also remove "can make the UI more comfy and pleasing by changing color , make card more pleasing , sliding bar matches with the color theme etc" point. maybe you can create another issue for this : )

@1Shubham7 1Shubham7 changed the title Some Changes and bugs that can be fixed [Feat] name block must be mandatory Oct 2, 2024
@1Shubham7 1Shubham7 added good first issue Good for newcomers gssoc-ext Issues under GSSoC label will be counted for GSSoC'24 extended hacktoberfest labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers gssoc-ext Issues under GSSoC label will be counted for GSSoC'24 extended hacktoberfest
Projects
None yet
Development

No branches or pull requests

5 participants
@1Shubham7 @manu-hn @Vijitverm1234 @Vatsal-Verma and others