Fix qodana issues

conflowgen/analyses/abstract_analysis.py

@@ -119,7 +119,7 @@ def _restrict_container_picked_up_by_vehicle_type(
         if container_picked_up_by_vehicle_type == "scheduled vehicles":
             container_picked_up_by_vehicle_type = ModeOfTransport.get_scheduled_vehicles()
             list_of_vehicle_types = container_picked_up_by_vehicle_type
-        if hashable(container_picked_up_by_vehicle_type) \
+        elif hashable(container_picked_up_by_vehicle_type) \
                 and container_picked_up_by_vehicle_type in set(ModeOfTransport):
             selected_containers = selected_containers.where(
                 Container.picked_up_by == container_picked_up_by_vehicle_type

conflowgen/application/services/export_container_flow_service.py

@@ -149,7 +149,7 @@ def _convert_table_to_pandas_dataframe(
         # extract data from sql database
         data = list(model.select().dicts())
 
-        if type(model) == ModelSelect:  # pylint: disable=unidiomatic-typecheck  # TODO: check if isinstance works
+        if isinstance(model, ModelSelect):
             model = model.model
 
         foreign_keys_to_resolve = {}

docs/conf.py

@@ -193,7 +193,7 @@
     database_names = ["demo_continental_gateway", "demo_deham_cta", "demo_poc"]  # List of database names to download
     sqlite_databases_directory = "notebooks/data/prepared_dbs/"
     os.system("echo 'Current directory:'")
-    os.system("pwd") # Print current directory; we expect to be in the docs folder
+    os.system("pwd")  # Print current directory; we expect to be in the docs folder
     os.makedirs(sqlite_databases_directory, exist_ok=True)  # Create the destination folder if it doesn't exist
     for database_name in database_names:
         os.system(f'echo "Fetching {database_name}"')

setup.py

@@ -53,6 +53,7 @@
             'parameterized',  # for parameterized testing
             'seaborn',  # some visuals in unittests are generated by seaborn
             'nbconvert',  # used to run tests in Jupyter notebooks, see ./test/notebooks/test_run_notebooks.py
+            'nbformat',  # used to run tests in Jupyter notebooks
 
             # build documentation
             'sphinx >=6.2',  # build the documentation - restrict version to improve pip version resolution