Merge pull request #19 from 21TORR/nullable-media-query

Allow nullable media queries

CHANGELOG.md

@@ -1,3 +1,9 @@
+0.5.1
+=====
+
+*   (improvement) Allow nullable media query (which will just compile away).
+
+
 0.5.0
 =====
 

mixins/media-query.scss

@@ -96,16 +96,18 @@
 	}
 
 	@if (list.length($list) == 0) {
-		@error "Can't create empty media query list";
+		@content;
 	}
+	@else {
+		$query: "screen";
 
-	$query: "screen";
+		@each $entry in $list {
+			$query: string.unquote("#{$query} and #{$entry}");
+		}
 
-	@each $entry in $list {
-		$query: string.unquote("#{$query} and #{$entry}");
+		@media #{$query} {
+			@content;
+		}
 	}
 
-	@media #{$query} {
-		@content;
-	}
 }

package.json

@@ -14,7 +14,7 @@
 	"devDependencies": {
 		"@types/node": "^14.14.6",
 		"@types/sass": "^1.16.0",
-		"ava": "^3.13.0",
+		"ava": "^3.15.0",
 		"esm": "^3.2.25",
 		"sass": "^1.28.0"
 	},

tests/mixins/media-query/on-media.test.js

@@ -27,19 +27,17 @@ test("on-media: Different parameter variations", t => {
 
 
 test("on-media: empty", t => {
-	const error = t.throws(
-		() => compileScss(`
-			@use "mixins/media-query";
-			
-			@include media-query.on-media() {
-				a {
-					color: red;
-				}
+	const css = compileScss(`
+		@use "mixins/media-query";
+		
+		@include media-query.on-media() {
+			a {
+				color: red;
 			}
-		`)
-	);
+		}
+	`);
 
-	t.regex(error.message, new RegExp(`Can't create empty media query list`));
+	t.is(css, `a{color:red}`);
 });