Review feedback

21TORR · Oct 25, 2024 · 17038f9 · 17038f9
1 parent f213ca5
commit 17038f9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -2,6 +2,7 @@
 ==========
 
 * The `createEvent` helper was removed, use `new CustomEvent()` directly.
+* The `handleHttpBasicAuth()` method was removed, use `integrateHttpBasicAuth()` directly
 
 
 1.x to 2.0

diff --git a/src/next/middleware/http-auth.ts b/src/next/middleware/http-auth.ts
@@ -20,7 +20,7 @@ export function handleHttpBasicAuth (
 {
 	return integrateHttpBasicAuth(
 		request,
-		[{username: username, password: password}],
+		[{username, password}],
 		responseText,
 		realmLabel
 	);
@@ -45,12 +45,12 @@ export function integrateHttpBasicAuth (
 			.toString()
 			.split(":");
 
-		users.forEach((item) => {
-			if (givenUser === item.username && givenPassword === item.password)
-			{
-				return;
-			}
-		})
+		const hasValidUser = users.some((item : Credentials) => givenUser === item.username && givenPassword === item.password);
+
+		if (hasValidUser)
+		{
+			return;
+		}
 	}
 
 	return new Response(responseText, {