From dbe77b85902bbe53659a9fa3b4804efda89f5fc5 Mon Sep 17 00:00:00 2001 From: YuviPanda Date: Tue, 18 May 2021 14:13:06 +0530 Subject: [PATCH] Clarify why we create a db per hub --- deployer/auth.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/deployer/auth.py b/deployer/auth.py index 8c8db1a800..4dff4e36cb 100644 --- a/deployer/auth.py +++ b/deployer/auth.py @@ -93,9 +93,10 @@ def ensure_client(self, name, domains, connection_name): current_connections = self.get_connections() if connection_name == 'password': - # All hubs attached to a single database 'connection' - # will share username / password. So we create one - # connection per hub. + # Users should not be shared between hubs - each hub + # should have its own username / password database. + # So we create a new 'database connection' per hub, + # instead of sharing one across hubs. db_connection_name = f'database-{name}' if db_connection_name not in current_connections: