Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all config generation in the deployer #1925

Closed
4 tasks done
Tracked by #1917
yuvipanda opened this issue Nov 16, 2022 · 1 comment · Fixed by #2349
Closed
4 tasks done
Tracked by #1917

Remove all config generation in the deployer #1925

yuvipanda opened this issue Nov 16, 2022 · 1 comment · Fixed by #2349
Assignees

Comments

@yuvipanda
Copy link
Member

yuvipanda commented Nov 16, 2022

From a right to replicate perspective, our end users should be able to take the config out of this repo, and be able to use a helm command to continue to deploy the hubs, passing in just the config. The current impediment to this is the bits of config we autogenerate from the deployer:

def get_generated_config(self, auth_provider: KeyProvider):
. That entire function should just go away. We'll just have to manually put in the config there as needed in all our hubs instead.

TODO:

yuvipanda added a commit to yuvipanda/pilot-hubs that referenced this issue Nov 16, 2022
We purely use ingress for HTTPS everywhere, so this is a noop.

Ref 2i2c-org#1925
yuvipanda added a commit to yuvipanda/pilot-hubs that referenced this issue Nov 16, 2022
yuvipanda added a commit to yuvipanda/pilot-hubs that referenced this issue Nov 16, 2022
yuvipanda added a commit to yuvipanda/pilot-hubs that referenced this issue Nov 16, 2022
yuvipanda added a commit to yuvipanda/pilot-hubs that referenced this issue Nov 16, 2022
yuvipanda added a commit to yuvipanda/pilot-hubs that referenced this issue Nov 16, 2022
@damianavila damianavila moved this from Ready to work to In progress in DEPRECATED Engineering and Product Backlog Nov 23, 2022
@GeorgianaElena GeorgianaElena self-assigned this Feb 15, 2023
@damianavila damianavila moved this to Todo 👍 in Sprint Board Mar 1, 2023
@damianavila damianavila moved this from Todo 👍 to In Progress ⚡ in Sprint Board Mar 15, 2023
@yuvipanda yuvipanda removed their assignment Mar 21, 2023
@github-project-automation github-project-automation bot moved this from In Progress ⚡ to Done 🎉 in Sprint Board Mar 24, 2023
@yuvipanda
Copy link
Member Author

Just absolutely amazing work, @GeorgianaElena!!!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants