Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup review comment about inlining multiple warnings #3134

Closed
consideRatio opened this issue Sep 13, 2023 · 1 comment
Closed

Followup review comment about inlining multiple warnings #3134

consideRatio opened this issue Sep 13, 2023 · 1 comment
Assignees
@consideRatio
Labels
allocation:internal-eng

Comments

@consideRatio
Copy link
Contributor

I'd like to think and respond to @GeorgianaElena's review comment in #3118 (comment), this issue represents that.
@consideRatio consideRatio self-assigned this Sep 13, 2023
@consideRatio consideRatio mentioned this issue Sep 13, 2023
Merged
14 tasks
@consideRatio
Copy link
Contributor Author

I failed to follow this up properly, but the gist of me wanting to have them inlined is that its a security thing that will be touched by community members etc that isn't us and will see this for the first time. I however also greatly appreciate not duplicating things like that though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@consideRatio consideRatio

Labels
allocation:internal-eng
Projects
No open projects
DEPRECATED Engineering and Product Backlog
Status: Needs Shaping / Refinement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuvipanda @consideRatio