-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jupyterhub-configurator to a newer commit #3197
Comments
Need to debug how things has changed using git history, as upgrading leads to a view looking like: Commits to compare: yuvipanda/jupyterhub-configurator@ed7e3a0...main |
Our config breaks against yuvipanda/jupyterhub-configurator@f356175 that removes |
I didn't get this done quick enough and can't finalize any fix this week. Whats known is:
|
I think we should just say jupyterhub-configurator is deprecated, leave it as is, and work on newer methodologies to handle the things it does - 2i2c-org/features#26 has more information. My inclination is to mark this as wontfix. |
The configurator's failure to function with JupyterHub 4.1.0 is blocking #3818, and its still actively used making removing it complicated. I don't want to have a z2jh upgrade blocked, and I don't want to quickly phase out the configurator and quickly phase in an alternative - due to that, I'd like to priotize this getting done. |
Ah, didn't realize it was blocking something else. Responded in #3818 (comment) |
I opened yuvipanda/jupyterhub-configurator#19 and then backported that work into a branch called I'll mark this issue to be closed by #3818 now |
I saw that jupyterhub-configurator is using an outdated commit from 2021, even though there are quite a few of more recent from at least 2022.
The text was updated successfully, but these errors were encountered: