Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jupyterhub-configurator to a newer commit #3197

Closed
consideRatio opened this issue Sep 30, 2023 · 7 comments
Closed

Update jupyterhub-configurator to a newer commit #3197

consideRatio opened this issue Sep 30, 2023 · 7 comments

Comments

@consideRatio
Copy link
Contributor

consideRatio commented Sep 30, 2023

I saw that jupyterhub-configurator is using an outdated commit from 2021, even though there are quite a few of more recent from at least 2022.

@consideRatio
Copy link
Contributor Author

Need to debug how things has changed using git history, as upgrading leads to a view looking like:

image

Commits to compare: yuvipanda/jupyterhub-configurator@ed7e3a0...main

@consideRatio
Copy link
Contributor Author

Our config breaks against yuvipanda/jupyterhub-configurator@f356175 that removes c.Configurator.schemas that we use.

@consideRatio
Copy link
Contributor Author

I didn't get this done quick enough and can't finalize any fix this week.

Whats known is:

  • With jupyterhub 4.1.0 with our current commit for jupyterhub-configurator, we get stuck like this:
    image
    image

  • With jupyterhub 4.1.0 with the latest commit for jupyterhub-configurator, we get stuck like this:
    image
    Due to breaking changes in yuvipanda/jupyterhub-configurator@f356175 removing Configurator.schemas that we configure in our Dockerfile, by loading .json files we've mounted on the hub pod via:

    extraFiles:
    configurator-schema-default:
    mountPath: /usr/local/etc/jupyterhub-configurator/00-default.schema.json
    data:
    type: object
    name: config
    properties:
    KubeSpawner.image:
    type: string
    title: User docker image
    description: Determines languages, libraries and interfaces available
    help: Leave this blank to use the default
    Spawner.default_url:
    type: string
    title: Default User Interface
    enum:
    - "/tree"
    - "/lab"
    - "/rstudio"
    default: "/tree"
    enumMetadata:
    interfaces:
    - value: "/tree"
    title: Classic Notebook
    description: >-
    The original single-document interface for creating
    Jupyter Notebooks.
    - value: "/lab"
    title: JupyterLab
    description: A Powerful next generation notebook interface
    - value: "/rstudio"
    title: RStudio
    description: An IDE For R, created by the RStudio company

@yuvipanda
Copy link
Member

I think we should just say jupyterhub-configurator is deprecated, leave it as is, and work on newer methodologies to handle the things it does - 2i2c-org/features#26 has more information. My inclination is to mark this as wontfix.

@consideRatio
Copy link
Contributor Author

The configurator's failure to function with JupyterHub 4.1.0 is blocking #3818, and its still actively used making removing it complicated. I don't want to have a z2jh upgrade blocked, and I don't want to quickly phase out the configurator and quickly phase in an alternative - due to that, I'd like to priotize this getting done.

@yuvipanda
Copy link
Member

Ah, didn't realize it was blocking something else. Responded in #3818 (comment)

@consideRatio
Copy link
Contributor Author

I opened yuvipanda/jupyterhub-configurator#19 and then backported that work into a branch called backported-jh41-compatibility that isn't breaking for our basehub chart to start using.

I'll mark this issue to be closed by #3818 now

@github-project-automation github-project-automation bot moved this from Needs Shaping / Refinement to Complete in DEPRECATED Engineering and Product Backlog May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants