Move homepage under custom.homepage #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref 2i2c-org#414 In preparation for strict schema validation of helm config from jupyterhub/zero-to-jupyterhub-k8s#2200
consideRatio
approved these changes
May 18, 2021
|
Thanks for the review, @consideRatio :) And yes, it does deploy if you press merge :) |
This was referenced May 18, 2021
Merged
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
May 18, 2021
Since 2i2c-org#417, homepage needs to be under jupyterhub.custom
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #414
In preparation for strict schema validation of helm config
from jupyterhub/zero-to-jupyterhub-k8s#2200