Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove decode_jpeg_* APIs? #860

Open
Daft-Freak opened this issue Sep 20, 2024 · 2 comments · May be fixed by #866
Open

Remove decode_jpeg_* APIs? #860

Daft-Freak opened this issue Sep 20, 2024 · 2 comments · May be fixed by #866

Comments

@Daft-Freak
Copy link
Collaborator

I've been thinking about this a bit:

  • As far as I can tell, decode_jpeg_buffer has two users (the example and my video player demo), decode_jpeg_file has none
  • They're a big chunk of code in the STM32 firmware (~6k text, ~5k bss)
  • Not even implemented in 32blit-pico
  • sdl2-image keeps causing dependency issues
  • It would probably be more useful to have something that wraps the same decoder everywhere on the user side of the API 🤔
@Gadgetoid
Copy link
Contributor

I wonder if anyone else has used this? JPEG is definitely one of the worst ways to get image data onto a microcontroller and we have an explicit pipeline for converting assets!

@ali1234
Copy link
Contributor

ali1234 commented Sep 21, 2024

I would much rather see that valuable firmware space used for something that is widely useful and benefits from being fast, like more drawing routines (#32), higher level multiplayer code, or more flexible menu system, or maybe even something like stagelib. Even just another font or some standard button sprites would be more useful.

@Daft-Freak Daft-Freak linked a pull request Oct 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants