Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roofer v1.0 overview #1

Open
36 of 37 tasks
Ylannl opened this issue Feb 16, 2024 · 0 comments
Open
36 of 37 tasks

Roofer v1.0 overview #1

Ylannl opened this issue Feb 16, 2024 · 0 comments

Comments

@Ylannl
Copy link
Member

Ylannl commented Feb 16, 2024

  • Transfer necessary function for building reconstruction from geoflow code (mostly gfp-building-reconstruction) and untangle from geoflow architecture. No big refactoring yet.
  • Build up and test building reconstruction pipeline (ie. what used to be reconstruct flowchart)
  • Make executable programs (crop and reconstruct) for running reconstruction pipeline by end user feature complete. Should be usable as drop in replacement for current geoflow reconstruct flowchart.
  • Develop API
  • Refactor code. Focus on common datatypes, minimise code duplication etc.
    • Update ArrangementOptimiser to latest CGAL api
    • remove proj dependency
    • Consistent logging
      • compile flag to turn off logging and remove dependency
      • make logging backend easily replaceable (Logging library #14)
    • Revise cmake build system, dependency management (vcpkg?) and project folder structure (Refactor the project layout #18)
    • test and set minimal versions for cmake dependencies + only require dependencies if targets are requested that need them
    • put everything in roofer namespaces
    • License in header of each file
    • consistent coding style (see how to set up clang-tidy and clang-format https://github.com/3DGI/roofer-dev/tree/develop/experiments/clang-tools) (Refactor the project layout #18)
    • update val3dity to current version (possibly need to refactor val3dity itself)
    • integrate jemalloc mimalloc
    • fix "Warning 1: Layer 'geom' has been declared with non-Z geometry type Polygon, but it does contain geometries with Z. Setting the Z=2 hint into gpkg_geometry_columns" in VectorWriter
  • Improvements to handle very large input data without needing a separate pre-tiling step
  • Improve error handling roofer app
    • don't crash if a building reconstruction fails but throw exception and continue reconstruction with next buildings/tiles.
    • output failed building with attribute reconstruction_status='failed'
  • Design + implement I/O efficient file format for CityJSON Sequences #10
  • Polish apps
    • Check if output paths exits and are writable prior to do expensive computations
    • Update cli parameters/usage
    • integrate crop/reconstruct apps into roofer
  • Documentation v1.0 #34
  • Automated testing
@Ylannl Ylannl transferred this issue from 3DGI/roofer Mar 20, 2024
@Ylannl Ylannl changed the title Roofer v1.0 Roofer v1.0 overview Apr 24, 2024
@Ylannl Ylannl modified the milestone: API complete Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant