Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding CityJSONSeq output options #93

Open
esgn opened this issue Dec 2, 2024 · 2 comments
Open

Question regarding CityJSONSeq output options #93

esgn opened this issue Dec 2, 2024 · 2 comments

Comments

@esgn
Copy link

esgn commented Dec 2, 2024

I tried generating using develop branch with different values of split-cjseq and omit-metadata in the config.toml file. Here are my findings :

split-cjseq omit-metadata Result
false false First CityJSONSeq metadata line present in city.jsonl tiles
false true First CityJSONSeq metadata line missing from city.jsonl tiles as expected.
This first line is not outputted anywhere else though.
true false First CityJSONSeq metadata line missing from city.jsonl objects.
This first line is outputted to a metadata.json file at root level inside output directory.
true true First CityJSONSeq metadata line missing from city.jsonl objects as expected.
This first line isn't outputted to a metadata.json file at root level inside output directory.

I would have expected :

  • Always getting the metadata line in CityJSONSeq output files when setting omit-metadata to false
  • Always getting the metadata line somewhere in a metadata.json file when omit-metadata is set to true so that the information remain available even though it is not included in the CityJSONSeq output files.

I may very well be missing information regarding the rationale behind these two options or missing experience with CityJSONSeq. Is what I'm noticing the expected behaviour ?

@Ylannl
Copy link
Member

Ylannl commented Dec 3, 2024

I understand the confusion. I implemented these options to support an internal workflow. But not all combinations of options make sense now, as you also point out. The metadata line with split-cjseq enabled may not be correct for all features either. I'll look into this and fix it. For now I recommend using the default values, this is most in line with the standard use of CityJSONSeq. Would this work for your use case?

@esgn
Copy link
Author

esgn commented Dec 4, 2024

Many thanks for the reply. We will stick to the default options for now. The full split and crop (split-cjseq and --crop-output) may be useful for debug purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants