Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests - Remove warnings from Javascript #5059

Closed
wants to merge 1 commit into from
Closed

Tests - Remove warnings from Javascript #5059

wants to merge 1 commit into from

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented Dec 2, 2024

In my Javascript IDE, I have plenty of warnings like :

image

@Gustry Gustry added tests unit tests and docker configuration for tests run end2end If the PR must run end2end tests or not backport release_3_7 backport release_3_8 backport release_3_9 labels Dec 2, 2024
@Gustry Gustry requested a review from nboisteault December 2, 2024 18:37
@github-actions github-actions bot added this to the 3.10.0 milestone Dec 2, 2024
@rldhont
Copy link
Collaborator

rldhont commented Dec 2, 2024

@Gustry lizmap-feature-toolbar is a custom element unknown by IDE. The way to fix is to extend the list of available HTML element in Lizmap Web Client project.

@Gustry Gustry force-pushed the ide-javascript-selector branch from f8b8e58 to 7c9a247 Compare December 2, 2024 19:50
@Gustry
Copy link
Member Author

Gustry commented Dec 2, 2024

Yes, I noticed, there are ways to overpass this, but not for now.

@Gustry Gustry closed this Dec 2, 2024
@Gustry Gustry deleted the ide-javascript-selector branch December 2, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nboisteault nboisteault Awaiting requested review from nboisteault

Assignees
No one assigned
Labels
backport release_3_7 backport release_3_8 backport release_3_9 run end2end If the PR must run end2end tests or not tests unit tests and docker configuration for tests
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Gustry @rldhont