Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up main view with project main data #5081

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Speed up main view with project main data #5081

merged 1 commit into from
Dec 5, 2024

Conversation

rldhont
Copy link
Collaborator

@rldhont rldhont commented Dec 4, 2024

Adding a class to get only project main data for main view

@github-actions github-actions bot added this to the 3.10.0 milestone Dec 4, 2024
@rldhont rldhont force-pushed the fix-project-main-data-view branch from e1be760 to d0a1ca3 Compare December 4, 2024 16:22
@rldhont rldhont mentioned this pull request Dec 4, 2024
Closed
@rldhont rldhont added the run end2end If the PR must run end2end tests or not label Dec 4, 2024
@rldhont rldhont force-pushed the fix-project-main-data-view branch from d0a1ca3 to d28b52d Compare December 4, 2024 17:55
@rldhont rldhont marked this pull request as ready for review December 4, 2024 18:15
@rldhont rldhont force-pushed the fix-project-main-data-view branch from d28b52d to d9a7a01 Compare December 4, 2024 18:16
@rldhont rldhont requested review from mdouchin, nworr and Gustry December 4, 2024 18:16
@rldhont
Speed up main view with project main data
34d78c5 
Adding a class to get only project main data for main view
@rldhont rldhont force-pushed the fix-project-main-data-view branch from d9a7a01 to 34d78c5 Compare December 4, 2024 18:50
nworr
nworr approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@nworr nworr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I made a suggestion about return type but it's a wider subject.

Thanks , specially for the tests

lizmap/modules/lizmap/lib/Project/ProjectMainData.php Show resolved Hide resolved
lizmap/modules/lizmap/lib/Project/ProjectMainData.php Show resolved Hide resolved
@mdouchin
Copy link
Collaborator

mdouchin commented Dec 5, 2024

Profile with XDebug on the index.php (Lizmap welcome page). Visualized with KCacheGrind in "Memory" mode. Complexity decreased

  • Current Master

image

  • This PR

image

@rldhont rldhont merged commit 6a34d3e into 3liz:master Dec 5, 2024
13 checks passed
This was referenced Dec 5, 2024
Merged
Merged
Merged
nboisteault pushed a commit to nboisteault/lizmap-web-client that referenced this pull request Dec 12, 2024
@rldhont
Merge pull request 3liz#5081 from rldhont/fix-project-main-data-view
966c620 
Speed up main view with project main data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nworr nworr nworr approved these changes

@mdouchin mdouchin mdouchin approved these changes

@nboisteault nboisteault nboisteault approved these changes

@Gustry Gustry Awaiting requested review from Gustry

Assignees
No one assigned
Labels
backport release_3_7 backport release_3_8 backport release_3_9 php Pull requests that update Php code run end2end If the PR must run end2end tests or not user interface
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rldhont @mdouchin @nboisteault @nworr