Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NoGeometry flag #56

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Remove NoGeometry flag #56

merged 2 commits into from
Jan 15, 2024

Conversation

ghtmtt
Copy link
Contributor

@ghtmtt ghtmtt commented Jan 15, 2024

  • Funded by: Faunalia
  • Description:
    • remove the NoGeometry flag when retrieving the QgsFeature

Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QGIS server uses the checkbox "Project properties → QGIS Server → WMS → Include geometry in the response", with https://api.qgis.org/api/namespaceQgsServerProjectUtils.html#a8ed7f6237fc3256071bdb1741fc725a2

Despite it's name (in API and GUI), it's not only in the response, but also to know if the geometry is needed when evaluating the HTML expression.

If you use an expression which needs the geometry in the native "HTML Maptip" on the server side, the expression won't work until the checkbox is checked.

Let's follow the same pattern, so the result is the same if the user switch between popup "QGIS HTML" or "Lizmap form".

@ghtmtt
Copy link
Contributor Author

ghtmtt commented Jan 15, 2024

@Gustry done

Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do you need a version or do you plan to have another fix/work soon ?

@Gustry Gustry merged commit ed6dfe7 into 3liz:master Jan 15, 2024
6 checks passed
@ghtmtt
Copy link
Contributor Author

ghtmtt commented Jan 15, 2024

no plans to add some other fixes/features soon. If you can make a release it would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants