Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid layer other than vector in the legend #77

Merged
merged 1 commit into from
May 16, 2024

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented May 15, 2024

Linked to 3liz/lizmap-web-client#4397

In the GetLegendGraphic, check all kind of layer if it is invalid or not

CC @guenterw

Copy link
Contributor

@rldhont rldhont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Gustry
Copy link
Member Author

Gustry commented May 15, 2024

Note for myself, I should check the JSON for a valid raster layer, just in case ...

@Gustry Gustry force-pushed the warning-all-invalid-layer branch 3 times, most recently from 91b7d83 to 016e73c Compare May 15, 2024 16:31
@Gustry Gustry force-pushed the warning-all-invalid-layer branch from 016e73c to 8644fea Compare May 15, 2024 16:33
@Gustry
Copy link
Member Author

Gustry commented May 15, 2024

@rldhont and @guenterw, to make tests passing, we can clearly notice how the legend was broken between 3.22 included and 3.34 excluded for raster.

So we should encourage people to migrate soon to 3.34.

@Gustry Gustry merged commit 5098057 into 3liz:master May 16, 2024
7 checks passed
@Gustry Gustry deleted the warning-all-invalid-layer branch May 16, 2024 06:32
@guenterw
Copy link

ok, I will pass this on to the German users (mailing list).

Regarding new functions, I'm sure everyone will understand. It is somewhat more annoying for the user if something no longer works in new versions as it used to in the older version (e.g. the legend in V3.7 with QGIS 3.22).
Technically, of course, I understand that. The alternative would have been that 3.7 could only be used with QGIS 3.28 or 3.34. It's always a compromise.

I personally plan to use 3.8 with QGIS 3.34 for major upgrades or new projects. Ideally under Ubuntu 24.04, provided this is available from my web host (Hetzner) in good time. Then hopefully there will be peace and quiet for a while :)

Thanks for the intensive work on Lizmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants