-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog/content/post/2024-11-26-measured-boot-improvements.md: Add post #613
Conversation
Signed-off-by: Michał Żygowski <[email protected]>
c34bf80
to
0b2f57e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great post, thank you, my comments are not blocking.
code. It may not be a big deal for modern platforms with big caches, but | ||
rather for the old ones. | ||
- coreboot supports only one algorithm in a single event log entry. | ||
Support for an agile format would have to be implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the current mitigation for that?
Can't we just set up an admin password so a change of PCR banks would not be possible for someone who doesn't know the password?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general even if an admin changes PCR banks, the change won't be applied or it will break measured boot.
The mitigation is like I described: be agile and calculate hashes for all currently enabled banks. Of course coreboot changes to event logging must follow.
Simply subject to future improvement. It is not about preventing the change of PCR banks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general even if an admin changes PCR banks, the change won't be applied or it will break measured boot.
So why are we not saying what mitigates that? Dear admin, do not change banks because it will break the system's trustworthiness. The admin must comply with that policy and should be informed about it. If the admin doesn't want users to change that policy, even accidentally, then prevent that by protecting the option with a password. That is the current mitigation. There should be a better one with the correct implementation, but that still needs to be implemented. We may be working on that. Or could you have a reference point to follow up?
… HSI results Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
…iness Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
…heads Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
@pietrushnic addressed all of the comments except #613 (comment) (treating it more like an open question) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed as well, and resolved threads from @pietrushnic
No description provided.