Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image still shown when switching to a different tmux session #198

Open
shurensha opened this issue Jul 24, 2024 · 13 comments · Fixed by #199
Open

Image still shown when switching to a different tmux session #198

shurensha opened this issue Jul 24, 2024 · 13 comments · Fixed by #199

Comments

@shurensha
Copy link
Contributor

shurensha commented Jul 24, 2024

How to reproduce:

  1. setup two tmux sessions (not windows)
  2. minimal config on first to display image
  3. prefix+L to navigate to second
  4. image is still displayed

Possibly related to: #106

tmux 3.4
kitty 0.35.2
nvim v0.10.0
image.nvim 61c7651

set -gq allow-passthrough on
set -g visual-activity off

screenshots

session 'notes'

image

session 'image_nvim'

image

@edte
Copy link

edte commented Jul 24, 2024

same problem, and also same nvim version and tmux version

@shurensha
Copy link
Contributor Author

shurensha commented Jul 24, 2024

same problem, and also same nvim version and tmux version

try my PR if it fixes it on your end

3rd added a commit that referenced this issue Jul 31, 2024
fix(kitty): image shown when switching to different tmux session #198
@Jendker
Copy link

Jendker commented Aug 12, 2024

Same issue on wezterm. The PR does not fix this, unfortunately. Please let me know if I should open a separate issue for wezterm.

@3rd
Copy link
Owner

3rd commented Aug 15, 2024

can you try this branch? https://github.com/3rd/image.nvim/tree/pr/199
branch is pr/199
it's not merged yet

xamcost added a commit to xamcost/nvim-config that referenced this issue Aug 15, 2024
to avoid sticking images when shifting between tmux panes (see
3rd/image.nvim#198 )
@Jendker
Copy link

Jendker commented Aug 15, 2024

Yes, it still happens on the pr/199 branch. I am using the default image.nvim config.

@davidfmatheson
Copy link

Same problem, tried with pr/199 branch, to no avail.

@3rd
Copy link
Owner

3rd commented Oct 2, 2024

This was fixed by @maxbol in #221 🙏

@maxbol
Copy link
Contributor

maxbol commented Oct 2, 2024

My PR was against the 199 branch, not sure if you noticed, but I think you might have merged it into that and then closed that branch @3rd ? 😀

@3rd
Copy link
Owner

3rd commented Oct 2, 2024

ah crap, sorry about that

@davidfmatheson
Copy link

Woohoo, this worked. Much appreciated.

@KilinW
Copy link

KilinW commented Oct 7, 2024

@davidfmatheson May I ask you how does it worked?
Mine still got a overlapped when I switch between tabs or sessions.
I'm already on the 88e9693 commit now.

@davidfmatheson
Copy link

@davidfmatheson May I ask you how does it worked?

I ran Lazy and updated the plugin, navigated to a markdown file with an image referenced, moved the cursor to that line, saw the image, left the cursor there and brought up my mix session picker (<leader>s for me), navigated to a different session, the image went away. It also goes away if I switch windows within a session.

I would note the image stayed visible on the session picker screen, but progress!

@3rd
Copy link
Owner

3rd commented Nov 2, 2024

I think it's the best we can do for now, other than hiding the images on focus lost, but that would not be pleasing either 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants