Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kitty): image shown when switching to different tmux session #198 #199

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix(kitty): image shown when switching to different tmux session #198 #199

merged 1 commit into from
Jul 31, 2024

Conversation

shurensha
Copy link
Contributor

fixes #198

steps to verify PR on issue above.

Approach:

  1. detect and clear image when attached session has changed
  2. detect and clear currently active pane tty across sessions

@3rd
Copy link
Owner

3rd commented Jul 24, 2024

Hey, thank you for your work, checking it out!
I'll probably merge it into a different branch first to replace the awk/xargs/etc part with Lua, and we can get it in <3

@3rd 3rd changed the base branch from master to pr/199 July 31, 2024 21:44
@3rd 3rd merged commit 838579b into 3rd:pr/199 Jul 31, 2024
@3rd
Copy link
Owner

3rd commented Jul 31, 2024

This is a bit problematic with multiple attached sessions, looking into it.

@3rd
Copy link
Owner

3rd commented Jul 31, 2024

@shurensha I think something like this should work https://github.com/3rd/image.nvim/tree/pr/199
Could you please try it out?

@3rd 3rd mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image still shown when switching to a different tmux session
2 participants
@shurensha @3rd