Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to demonstrate semantics of gRPC clients when server gets shutdown and client never calls Finish() #573

Open
benh opened this issue Sep 13, 2022 · 1 comment

Comments

@benh
Copy link
Member

benh commented Sep 13, 2022

We currently have tests to show that a gRPC client does not need to call Finish() but can simply get destructed.

It appears that this does not work when the server gets destructed, however, and that a client must call Finish() in that case, i.e., it can't just get destructed. We should write a test that demonstrates this as well as consider adding some functionality into our client code that makes this better.

@benh
Copy link
Member Author

benh commented Sep 13, 2022

@while-false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant