Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling #8

Open
erhhung opened this issue May 8, 2014 · 1 comment
Open

Error handling #8

erhhung opened this issue May 8, 2014 · 1 comment

Comments

@erhhung
Copy link

erhhung commented May 8, 2014

I see that all of the client auth methods are not listening on the https.request 'error' event, and so when a lower level network error occurs, my app has no way of handling the auth failure, and the process just exits. For example, if I'm testing my app behind a firewall proxy, the call will eventually time out:

Error: connect ETIMEDOUT
at errnoException (net.js:901:11)
at Object.afterConnect as oncomplete

I also see simple error strings being 'throw'n on failures, and my callback has no way to handle those, either, due to the async functions. I know I can use a global unhandledException handler, but that's not recommended.

@mpguerra
Copy link

mpguerra commented Dec 9, 2016

@picsoung same with this one, not sure if related to #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants