Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bindgen dependancy? #4

Closed
hakanols opened this issue Oct 2, 2020 · 2 comments
Closed

Remove bindgen dependancy? #4

hakanols opened this issue Oct 2, 2020 · 2 comments

Comments

@hakanols
Copy link

hakanols commented Oct 2, 2020

I am new to Rust so take my suggestion with a huge grain of salt.
To simplify for new users it would be great to remove the clang and bindgen dependency.

I have noticed that issue that is listed as the reason for bindgen in https://github.com/thejpster/nrfxlib-sys is closed:
rust-lang/cargo#5730

Guess Cargo issue 5730 not solving the problem but should it not be possible to solve this with something precompiled like they do in:
https://github.com/rusqlite/rusqlite#binding-generation

BR Håkan

@jonathanpallant
Copy link
Contributor

Has #5730 made it through to stable? If so, I'm happy to turn bindgen back into a build time dependency.

I considered precompilation, but I'm not a fan in general, as it's far too easy for the compiled objects and the source code to get out of step.

@hakanols
Copy link
Author

You are correct. #5730 has not made it to stable at the time of writing. My bad.

You are more knowledgable on the subject of precompiling for Rust than me.

BR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants