New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declarative instructions must make use of the standard Bean parser wherever possible #27

Open

robert-bor opened this issue Mar 3, 2013 · 0 comments

Assignees

Labels

Milestone

Contributor

robert-bor commented Mar 3, 2013

When annotations are used, a Bean is parsed and default indexes are drawn up.

This should also be done when annotations are not used.

At the moment you still have to declare a number of steps which are unnecessary:

        CsvReader<Bean> csvReader = new CsvReaderImpl<Bean>(reader, new BeanReaderInstructionsImpl(Bean.class))
                .setMapper(ColumnNameMapper.class)
                .mapColumnNameToProperty("name", "name")
                .mapColumnNameToProperty("number", "number")
                .mapColumnNameToProperty("date", "date")
                .setDate("date", "dd-MM-yyyy");

This should be:

        CsvReader<Bean> csvReader = new CsvReaderImpl<Bean>(reader, new BeanReaderInstructionsImpl(Bean.class))
                .setMapper(ColumnNameMapper.class)
                .setDate("date", "dd-MM-yyyy");

ghost assigned robert-bor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment